Do the same checks in codecs than in codec_choose #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditional code is now only dependent on config.h values in codecs except for NEON which also includes the same checks as in codec_choose. This fixes mayeut/pybase64#8 and probably aklomp#40
|
Merged, thanks. Personally I liked the idea of trusting the compiler's builtin platform vars over the stuff that the user puts on the commandline, but I can see how it fails to be portable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC compiler does not define those
__SIMD__(e.g.__AVX__) predefined macros.Conditional code is now only dependent on config.h values in all
codec.cfiles except for NEON which also includes the same checks as incodec_choose.c.This fixes mayeut/pybase64#8 and probably #40